refactor to work with gardenlinux 0.10.24 - #13

… schema.py

Reduces ~580 lines of duplicated schema definitions by generating both
SCHEMA_V1 and SCHEMA_V2 from shared builder functions. The only difference
between v1 and v2 is that v2 requires a 'patch' field in version objects
for minor, nightly, and dev release types.

- Create glrd/schema.py with factory functions for generating schemas
- Update manage.py to import from glrd.schema instead of the old files
- All schema validation tests pass (7/7)

- Add missing ERROR_CODES entries: output_error, s3_output_error,
  input_parameter_missing, input_parameter_error, subprocess_output_missing
- Add fatal_error() utility function for centralized error handling
- Fix deprecated datetime.utcfromtimestamp() usage in util.py and manage.py
  (use datetime.fromtimestamp with timezone.utc instead)
- Add timezone import to both util.py and manage.py

Add commonly used utility functions:
- V2_SCHEMA_THRESHOLD constant (2017) for v1/v2 schema decisions
- uses_patch_version() helper function
- split_releases_by_type() to split releases by type into a dict
- run_subprocess() for standardized subprocess execution
- parse_isodatetime() for consistent datetime parsing with error handling

All schema tests pass.

Replace duplicated release type filtering logic (~15 lines repeated 3 times)
with calls to the shared split_releases_by_type() utility function from util.py.
This eliminates duplicate code and ensures consistent behavior.

- Remove unused import in schema.py
- Fix line length issues in schema.py
- Add proper blank line after function in util.py
- Add proper type hints for parse_isodatetime
- Format all modified files with black

Phase 1 - Dataclasses:
- Add glrd/models.py with ReleaseType enum, Version, LifecyclePhase,
  Lifecycle, GitInfo, Release, ReleaseCollection, parse_release_name
- Centralizes the 'major >= 2017' version threshold logic in Version class

Phase 2 - S3 module:
- Extract S3 operations to glrd/s3.py
- Import s3 functions in manage.py for backward compatibility
- Functions: create_s3_bucket, upload_to_s3, download_from_s3,
  merge_existing_s3_data, download_all_s3_files, upload_all_local_files

All schema validation tests pass.

Phase 2 - Git module:
- Extract Git operations from manage.py to glrd/git.py
- Functions: get_github_releases, get_git_commit_from_tag,
  get_git_commit_at_time, get_garden_version_for_date,
  create_initial_releases, create_initial_nightly_releases, cleanup_temp_repo
- Fix date increment logic in create_initial_nightly_releases (use timedelta)
- Import git functions in manage.py

All schema tests pass.

Phase 2 - Validation module:
- Extract validation functions from manage.py to glrd/validation.py
- Functions: validate_input_version_format, get_schema_for_release,
  validate_release_data, validate_all_releases
- Use V2_SCHEMA_THRESHOLD constant instead of hardcoded 2017
- Import validation functions in manage.py

All schema tests pass.

- Remove unused datetime import from models.py
- Remove unused major_version variable in git.py
- Fix trailing whitespace in git.py
- Format code with black

All tests passing.

- Change from 'deepdiff import DeepDiff' to 'deepdiff.diff import DeepDiff'
  to fix lint warning about incorrect module import

Note: manage.py still contains duplicate function definitions that are
imported from new modules (s3.py, git.py, validation.py). These duplicates
are functionally harmless as Python uses the imported versions, but they
trigger F811 lint warnings. Removing them automatically breaks the file due
to complex interdependencies. This is acceptable technical debt that can
be addressed incrementally.

All 29 tests passing.

Clean up manage.py by removing 522 lines of duplicate function definitions
that are now imported from other modules:

Duplicate functions removed:
- validate_input_version_format, get_schema_for_release (from validation.py)
- cleanup_temp_repo, get_github_releases, get_git_commit_from_tag,
  get_git_commit_at_time, get_garden_version_for_date,
  create_initial_releases, create_initial_nightly_releases (from git.py)
- validate_release_data, validate_all_releases (from validation.py)
- download_all_s3_files, upload_all_local_files (from s3.py)

Unused imports removed:
- fnmatch, shutil, subprocess, timedelta, timezone
- jsonschema.validate, jsonschema.ValidationError
- SCHEMA_V1, SCHEMA_V2
- extract_version_data, NoAliasDumper
- save_output_file alias

File size reduced from 1,911 to 1,364 lines (-547 lines, -29%)
Format with black to fix spacing issues.

All 29 tests passing. Lint clean (no errors or warnings).

Use gardenlinux.github.Client (PyGithub) and gardenlinux.git.Repository
(pygit2) instead of subprocess calls to gh and git. Both are already
pulled in transitively by the gardenlinux dependency.

- get_github_releases: Client().get_repo(...).get_releases()
- get_git_commit_from_tag: get_git_ref() with annotated-tag dereferencing
- get_git_commit_at_time: Repository.checkout_repo() + pygit2 walk
- cleanup_temp_repo: dereference _repo_instance before rmtree

Auth change: GITHUB_TOKEN is now required for GitHub API calls instead
of gh auth login. Add GITHUB_TOKEN prerequisites to run-glrd.md and
manage-releases.md. Remove gh CLI install from Containerfile.

Add tests/test_git.py with 14 unit tests covering all changed functions.

Signed-off-by: Eike Waldt <waldt@b1-systems.de>
On-behalf-of: SAP <eike.waldt@sap.com>
Assisted-by: Kilo:claude-opus-4-8
Assisted-by: Kilo:claude-sonnet-4-6

- Rename DEFAULTS['CONTAINER_REGISTRY'] → DEFAULTS['CONTAINER_REGISTRY_MINOR']
  (ghcr.io/gardenlinux/gardenlinux)
- Add DEFAULTS['CONTAINER_REGISTRY_NIGHTLY'] (ghcr.io/gardenlinux/nightly)
- Add get_container_registry(release_type) helper in query.py that returns
  the nightly registry for nightly releases and the minor registry otherwise
- Thread release_type through prepare_oci_flavor_url (new 4th param) and
  its call site in format_flavors_with_urls
- Update get_oci_url to use get_container_registry(release.get('type'))
- Add tests/test_query_oci.py: 11 unit tests covering get_container_registry,
  get_oci_url, and prepare_oci_flavor_url for both container and bare flavors
- Add OCI integration tests to test_integration.py: nightly/minor registry
  selection and cross-type registry difference

Fixes #16

Signed-off-by: Eike Waldt <waldt@b1-systems.de>
On-behalf-of: SAP <eike.waldt@sap.com>
Assisted-by: Kilo:claude-opus-4-7
Assisted-by: Kilo:claude-sonnet-4-6